docs: Clarify ingress-nginx ssl termination example #13913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtsmith
changed the title
rtsmith
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #13913 +/- ##
==========================================
- Coverage 49.57% 49.56% -0.01%
==========================================
Files 256 256
Lines 43920 43920
==========================================
- Hits 21773 21770 -3
- Misses 19985 19987 +2
- Partials 2162 2163 +1 ☔ View full report in Codecov by Sentry. |
morey-tech
reviewed
Jun 6, 2023
Signed-off-by: Thomas Smith <tom@solrr.net>
Co-authored-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Tom Smith <rtsmith@users.noreply.github.com>
morey-tech
approved these changes
Jun 6, 2023
pasha-codefresh
approved these changes
Jun 14, 2023
|
LGTM, thank you |
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
* Clarify ingress-nginx ssl termination example Signed-off-by: Thomas Smith <tom@solrr.net> * Expand on ingress-nginx ssl termination section context Co-authored-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Tom Smith <rtsmith@users.noreply.github.com> --------- Signed-off-by: Thomas Smith <tom@solrr.net> Signed-off-by: Tom Smith <rtsmith@users.noreply.github.com> Co-authored-by: Nicholas Morey <nicholas@morey.tech> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* Clarify ingress-nginx ssl termination example Signed-off-by: Thomas Smith <tom@solrr.net> * Expand on ingress-nginx ssl termination section context Co-authored-by: Nicholas Morey <nicholas@morey.tech> Signed-off-by: Tom Smith <rtsmith@users.noreply.github.com> --------- Signed-off-by: Thomas Smith <tom@solrr.net> Signed-off-by: Tom Smith <rtsmith@users.noreply.github.com> Co-authored-by: Nicholas Morey <nicholas@morey.tech> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.
This PR attempts to improve the docs for terminating SSL at ingress controller by:
do not change, this is provided by Argo CDcomment on secretName declaration. In this example, we are not terminating SSL at argocd server, so we don't need this TLS cert inargocd-server-tlssecret. Even better to not have it there in this case.