Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade go to 1.20.5 #13941

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

crenshaw-dev
Copy link
Member

Get some important security upgrades: https://go.dev/doc/devel/release#go1.20.minor

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Dockerfile Show resolved Hide resolved
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev Is there an updated 1.20.4 that we should be patching back to 2.6 and 2.5?

@crenshaw-dev
Copy link
Member Author

@todaywasawesome I believe 2.5 and 2.6 are on go 1.18, which did not receive a patch. idk if it went unpatched because it was unaffected, or because it's past EOL.

@crenshaw-dev
Copy link
Member Author

Ah, 2.6 was on 1.19, and I opened a PR for it. #13943

Copy link
Member

@34fathombelow 34fathombelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crenshaw-dev crenshaw-dev added the security Security related label Jun 13, 2023
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit 0faa56b into argoproj:master Jun 14, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Security related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants