Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Consistently default to linux/amd64 #14146

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

jsoref
Copy link
Member

@jsoref jsoref commented Jun 21, 2023

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (4ca903b) 49.61% compared to head (28d35d5) 49.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14146      +/-   ##
==========================================
+ Coverage   49.61%   49.64%   +0.02%     
==========================================
  Files         256      256              
  Lines       43925    43914      -11     
==========================================
+ Hits        21793    21800       +7     
+ Misses      19975    19958      -17     
+ Partials     2157     2156       -1     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsoref jsoref changed the title Consistently default to linux/amd64 ci: Consistently default to linux/amd64 Jun 21, 2023
@jsoref jsoref marked this pull request as draft June 21, 2023 01:01
@jsoref jsoref marked this pull request as ready for review June 21, 2023 01:17
@jsoref jsoref requested a review from jannfis June 21, 2023 02:17
Signed-off-by: Josh Soref <jsoref@gmail.com>
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jannfis jannfis changed the title ci: Consistently default to linux/amd64 build: Consistently default to linux/amd64 Jun 21, 2023
@jannfis jannfis merged commit be0edcd into argoproj:master Jun 21, 2023
@jsoref jsoref deleted the linux-amd64 branch June 22, 2023 02:32
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Josh Soref <jsoref@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Josh Soref <jsoref@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants