fix: fix permanent vertical scroll and left marging on project details page #14181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s page Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
requested review from
rbreeze and
keithchong
and removed request for
rbreeze
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #14181 +/- ##
=======================================
Coverage 49.61% 49.62%
=======================================
Files 256 256
Lines 43800 43800
=======================================
+ Hits 21733 21736 +3
+ Misses 19934 19932 -2
+ Partials 2133 2132 -1 ☔ View full report in Codecov by Sentry. |
jmeridth
approved these changes
Jun 23, 2023
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…s page (argoproj#14181) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…s page (argoproj#14181) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR partially addresses #13827
PR removes permanent vertical scroll on application details page and removes invalid left margin that shifted everything left and broken toolbar on project details page.
Before:
Screen.Recording.2023-06-22.at.3.50.14.PM.mov
After:
Screen.Recording.2023-06-22.at.3.50.51.PM.mov