Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action): copy metadata on create-job action (#14232) #14233

Merged

Conversation

crenshaw-dev
Copy link
Member

Fixes #14232

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev requested a review from reggie-k June 27, 2023 16:55
@crenshaw-dev crenshaw-dev marked this pull request as ready for review June 27, 2023 16:55
@crenshaw-dev
Copy link
Member Author

/cherry-pick release-2.8

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (40e26fc) 49.78% compared to head (3d18155) 49.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #14233   +/-   ##
=======================================
  Coverage   49.78%   49.78%           
=======================================
  Files         261      261           
  Lines       44672    44672           
=======================================
  Hits        22238    22238           
  Misses      20249    20249           
  Partials     2185     2185           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pasha-codefresh pasha-codefresh merged commit faaa302 into argoproj:master Jul 11, 2023
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 11, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jul 11, 2023
…4453)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…oproj#14233)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@suzaku suzaku mentioned this pull request Aug 15, 2023
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…oproj#14233)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Job (2.8.0-rc1) deep copy bug when creating Job from Cronjob
3 participants