fix: Change disallowed application destination message (#14284)

[michaelkotelnikov]

Fixes #14284

Applications that do not have a spec.destination.namespace definition in namespace scoped AppProjects provide a clearer message. Helpful when troubleshooting applicationsets that are unable to create applications and produced unclear logs.

The message was changed from -

Unable to create application: application spec for appname is invalid: InvalidSpecError: application destination {https://kubernetes.default.svc } is not permitted in project 'default'

To -

Unable to create application: application spec for appname is invalid: InvalidSpecError: application destination server 'https://kubernetes.default.svc' and namespace '' do not match any of the allowed destinations in project 'default'

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5f455af) 49.76% compared to head (6f65f49) 49.76%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #14307   +/-   ##
=======================================
  Coverage   49.76%   49.76%           
=======================================
  Files         261      261           
  Lines       44676    44676           
=======================================
  Hits        22232    22232           
  Misses      20257    20257           
  Partials     2187     2187           

Impacted Files	Coverage Δ
util/argo/argo.go	66.45% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[crenshaw-dev]

/cherry-pick release-2.8