Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade dexIDP from 2.36.0 -> 2.37.0 Closes [14305] #14310

Merged
merged 2 commits into from
Jul 3, 2023
Merged

feat: upgrade dexIDP from 2.36.0 -> 2.37.0 Closes [14305] #14310

merged 2 commits into from
Jul 3, 2023

Conversation

venkatamutyala
Copy link
Contributor

@venkatamutyala venkatamutyala commented Jul 2, 2023

Note on DCO:

For the most part v2.37.0 contains a lot of dependency updates: https://github.com/dexidp/dex/releases/tag/v2.37.0, which should only improve the stability/security of dexIDP. This update includes a couple of changes, but should not break any existing functionality:

Given the changes shouldn't break anything, I don't see a reason to call them out in the argo-cd documentation.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>
Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5f455af) 49.76% compared to head (5961d42) 49.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #14310   +/-   ##
=======================================
  Coverage   49.76%   49.76%           
=======================================
  Files         261      261           
  Lines       44676    44676           
=======================================
  Hits        22232    22232           
  Misses      20257    20257           
  Partials     2187     2187           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit b9fefca into argoproj:master Jul 3, 2023
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.8

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 3, 2023
* feat: update dexidp image tag from v2.36.0 -> v2.37.0

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>

* chore: adding GlueOps to USERS.md

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>

---------

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.7

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error b9fefca17b81f716e6cbc83a637077f75bdbdfb1 into temp-cherry-pick-9918ce-release-2.7

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.6

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error b9fefca17b81f716e6cbc83a637077f75bdbdfb1 into temp-cherry-pick-9918ce-release-2.6

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.5

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error b9fefca17b81f716e6cbc83a637077f75bdbdfb1 into temp-cherry-pick-9918ce-release-2.5

@crenshaw-dev
Copy link
Member

@venkatamutyala would you mind opening cherry-pick PRs for 2.5-2.7?

crenshaw-dev pushed a commit that referenced this pull request Jul 3, 2023
* feat: update dexidp image tag from v2.36.0 -> v2.37.0



* chore: adding GlueOps to USERS.md



---------

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>
Co-authored-by: Venkata Mutyala <venkata@venkatamutyala.com>
crenshaw-dev pushed a commit that referenced this pull request Jul 3, 2023
* feat: update dexidp image tag from v2.36.0 -> v2.37.0



* chore: adding GlueOps to USERS.md



---------

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>
crenshaw-dev pushed a commit that referenced this pull request Jul 3, 2023
* feat: update dexidp image tag from v2.36.0 -> v2.37.0



* chore: adding GlueOps to USERS.md



---------

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>
crenshaw-dev pushed a commit that referenced this pull request Jul 3, 2023
* feat: update dexidp image tag from v2.36.0 -> v2.37.0



* chore: adding GlueOps to USERS.md



---------

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
…#14310) (argoproj#14322)

* feat: update dexidp image tag from v2.36.0 -> v2.37.0

* chore: adding GlueOps to USERS.md

---------

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…#14310)

* feat: update dexidp image tag from v2.36.0 -> v2.37.0

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>

* chore: adding GlueOps to USERS.md

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>

---------

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>
@suzaku suzaku mentioned this pull request Aug 15, 2023
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…#14310)

* feat: update dexidp image tag from v2.36.0 -> v2.37.0

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>

* chore: adding GlueOps to USERS.md

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>

---------

Signed-off-by: Venkata Mutyala <venkata@venkatamutyala.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants