Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump to 2.7.7 #14331

Closed

Conversation

shivamgupta211-fx
Copy link

@shivamgupta211-fx shivamgupta211-fx commented Jul 4, 2023

Bumping to v2.7.7

Cherrypicked 8f2750c

Issue: #14127

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

pasha-codefresh and others added 2 commits July 4, 2023 14:28
* feat: update notification-engine dependency to latest version

* feat: update notification-engine dependency to latest version
@crenshaw-dev
Copy link
Member

@shivamgupta211-fx I believe this change is also unnecessary. The release workflow will bump the version when we cut a release. Can you describe what you're trying to solve?

@crenshaw-dev
Copy link
Member

Oh! This is to cherry-pick back the argocd-notifications upgrade? If so, no need for the 2.7.7 bumps, that's done by the github workflow.

I'm not sure we want to upgrade notifications engine within a minor release, since it introduces new features. Is there a bug fix you need picked back?

@shivamgupta211-fx
Copy link
Author

@crenshaw-dev thanks for responding.
My main goal is to use the notification engine with the latest commit as it contains the changes which are required for our use-case.

Now the problem is, these changes are present in the master but not in the last stable tag/build i.e. v2.7.6

I raised this PR to fix the issue.

Let me know how can I push the latest notification to either v2.7.6 or to the next release v2.7.7?

@crenshaw-dev
Copy link
Member

@shivamgupta211-fx which features/fixes do you need? We generally don't add new features to minor release series, so if you need a new feature, it might have to wait for 2.8.

@shivamgupta211-fx
Copy link
Author

@crenshaw-dev
specifically, pagerDutyv2 feature

argoproj/notifications-engine#105

@crenshaw-dev
Copy link
Member

Yeah, I think that'll have to wait for 2.8. The RC is out, GA is scheduled for ~1mo from now.

@shivamgupta211-fx
Copy link
Author

Thanks, @crenshaw-dev

We will wait for the 2.8.x release then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants