chore: cherry-pick (#14348) Add support for self-signed TLS / Certificates for Gitlab Scm Provider #14462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ab Scm Provider (#14348) * Add support for self-signed TLS / Certificates for Gitlab Scm Provider Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add support for self-signed TLS / Certificates for Gitlab Pull Request Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add TLS configuration for SCM and Pull request Gitlab Provider Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * rebase with master Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * add params to argocd-cmd-params-cm and docs Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix generated manifests Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Address comments for docs Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Add test cases to validate insecure mode and ca cert combinations Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * simplify (#24) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
approved these changes
Jul 11, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-2.8 #14462 +/- ##
===============================================
+ Coverage 49.75% 49.77% +0.02%
===============================================
Files 261 261
Lines 44701 44748 +47
===============================================
+ Hits 22240 22274 +34
- Misses 20276 20285 +9
- Partials 2185 2189 +4
☔ View full report in Codecov by Sentry. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick (#14348)Add support for self-signed TLS / Certificates for Gitlab Scm Provider
Signed-off-by: ishitasequeira ishiseq29@gmail.com