Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve ignoreResourceUpdates logging #14476

Conversation

crenshaw-dev
Copy link
Member

Having the resource server name/URL for stats would be handy.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (927b940) 49.75% compared to head (d01fc06) 49.75%.

❗ Current head d01fc06 differs from pull request most recent head 7a1e02c. Consider uploading reports for the commit 7a1e02c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14476      +/-   ##
==========================================
- Coverage   49.75%   49.75%   -0.01%     
==========================================
  Files         261      261              
  Lines       44754    44756       +2     
==========================================
- Hits        22268    22267       -1     
- Misses      20295    20297       +2     
- Partials     2191     2192       +1     
Impacted Files Coverage Δ
controller/appcontroller.go 53.95% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pasha-codefresh pasha-codefresh merged commit 00917d1 into argoproj:master Jul 13, 2023
@crenshaw-dev crenshaw-dev deleted the improve-ingoreresourceupdates-logging branch July 13, 2023 14:44
@crenshaw-dev
Copy link
Member Author

/cherry-pick release-2.8

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 13, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
crenshaw-dev added a commit that referenced this pull request Jul 13, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Jneville0815 pushed a commit to radiusmethod/argo-cd that referenced this pull request Jul 18, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
@suzaku suzaku mentioned this pull request Aug 15, 2023
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants