Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove executable bit from default file mode #14497

Merged
merged 3 commits into from
Jul 18, 2023
Merged

fix: Remove executable bit from default file mode #14497

merged 3 commits into from
Jul 18, 2023

Conversation

ramikg
Copy link
Contributor

@ramikg ramikg commented Jul 13, 2023 •
edited
Loading

Untgz unnecessarily calls os.OpenFile with a file mode which has all executable bits set.
This PR removes the executable bits.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@ramikg ramikg changed the title Remove executable bit from default file mode fix: Remove executable bit from default file mode Jul 13, 2023
@ramikg
Fix file/directory opening mode
b64a783 
Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
@crenshaw-dev
Copy link
Member

I like this change, but it is a departure from the default in 2.7, which is "all files are executable.

I'm in favor of merging this, as long as there's a note in the 2.7-2.8 release docs explaining the change.

ramikg added 2 commits July 13, 2023 20:55
@ramikg
Fix TestUntgz/preserves_file_mode
598267d 
Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
@ramikg
Mention file mode fix in 2.7-2.8 release docs
284823d 
Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
@ramikg
Copy link
Contributor Author

ramikg commented Jul 13, 2023

Thank you, I've added a note.

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.8

@crenshaw-dev crenshaw-dev merged commit dd800ec into argoproj:master Jul 18, 2023
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 18, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 18, 2023
@ramikg
fix: Remove executable bit from default file mode (#14497)
049c02a 
* Fix file/directory opening mode

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>

* Fix TestUntgz/preserves_file_mode

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>

* Mention file mode fix in 2.7-2.8 release docs

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>

---------

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
crenshaw-dev pushed a commit that referenced this pull request Jul 18, 2023
@gcp-cherry-pick-bot @ramikg
fix: Remove executable bit from default file mode (#14497) (#14576)
af7f8af 
* Fix file/directory opening mode



* Fix TestUntgz/preserves_file_mode



* Mention file mode fix in 2.7-2.8 release docs



---------

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
Co-authored-by: Rami <72725910+ramikg@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@ramikg
fix: Remove executable bit from default file mode (argoproj#14497)
68c190c 
* Fix file/directory opening mode

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>

* Fix TestUntgz/preserves_file_mode

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>

* Mention file mode fix in 2.7-2.8 release docs

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>

---------

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
@suzaku suzaku mentioned this pull request Aug 15, 2023
Closed
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@ramikg @tesla59
fix: Remove executable bit from default file mode (argoproj#14497)
dcc6e95 
* Fix file/directory opening mode

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>

* Fix TestUntgz/preserves_file_mode

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>

* Mention file mode fix in 2.7-2.8 release docs

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>

---------

Signed-off-by: ramikg <72725910+ramikg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramikg @crenshaw-dev