fix(controller): populate ignoreDifferences in sync status #14542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
/cherry-pick release-2.8 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #14542 +/- ##
=======================================
Coverage 49.79% 49.80%
=======================================
Files 261 261
Lines 44751 44757 +6
=======================================
+ Hits 22283 22289 +6
Misses 20274 20274
Partials 2194 2194
☔ View full report in Codecov by Sentry. |
|
Fixes continuous loop of
|
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 17, 2023
Jneville0815
pushed a commit
to radiusmethod/argo-cd
that referenced
this pull request
Jul 18, 2023
…14542) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…14542) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
…14542) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was incomplete. It correctly checks whether ignoreDifferences was changed since the last sync and requests a new sync if it wasn't. But it incorrectly fails to populate the ignoreDifferences field in the last sync state. So for any app with ignoreDifferences set, refreshes will be constantly requested.