Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Correct example ClusterRole to allow Events in any namespace (#14477) #14544

Merged
merged 1 commit into from
Jul 17, 2023
Merged

docs: Correct example ClusterRole to allow Events in any namespace (#14477) #14544

merged 1 commit into from
Jul 17, 2023

Conversation

dgeorgievski
Copy link
Contributor

Fixes: #14477

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [ x] The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@dgeorgievski
fix: Correct example ClusterRole to allow Events in any namespace
d9792ec 
Fixes: argoproj#14477
Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
@crenshaw-dev crenshaw-dev changed the title fix: Correct example ClusterRole to allow Events in any namespace. Fixes #14477 fix: Correct example ClusterRole to allow Events in any namespace (#14477) Jul 17, 2023
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.8

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.7

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.6

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.5

@crenshaw-dev crenshaw-dev changed the title fix: Correct example ClusterRole to allow Events in any namespace (#14477) docs: Correct example ClusterRole to allow Events in any namespace (#14477) Jul 17, 2023
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) July 17, 2023 15:50
@crenshaw-dev crenshaw-dev merged commit a577866 into argoproj:master Jul 17, 2023
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 17, 2023
@dgeorgievski
docs: Correct example ClusterRole to allow Events in any namespace (#…
afd8b1b 
…14544)

Fixes: #14477

Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 17, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 17, 2023
@dgeorgievski
docs: Correct example ClusterRole to allow Events in any namespace (#…
7f1458e 
…14544)

Fixes: #14477

Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
This was referenced Jul 17, 2023
Merged
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 17, 2023
@dgeorgievski
docs: Correct example ClusterRole to allow Events in any namespace (#…
1883660 
…14544)

Fixes: #14477

Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error a57786657bc26f66e55fb30b66463fe18625459d into temp-cherry-pick-80bcdd-release-2.5

crenshaw-dev pushed a commit that referenced this pull request Jul 17, 2023
@gcp-cherry-pick-bot @dgeorgievski
docs: Correct example ClusterRole to allow Events in any namespace (#…
05645b0 
…14544) (#14550)

Fixes: #14477

Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
Co-authored-by: Dimitar Georgievski <dgeorgievski@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Jul 17, 2023
@gcp-cherry-pick-bot @dgeorgievski
docs: Correct example ClusterRole to allow Events in any namespace (#…
da5dab7 
…14544) (#14551)

Fixes: #14477

Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
Co-authored-by: Dimitar Georgievski <dgeorgievski@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Jul 17, 2023
@gcp-cherry-pick-bot @dgeorgievski
docs: Correct example ClusterRole to allow Events in any namespace (#…
a117187 
…14544) (#14552)

Fixes: #14477

Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
Co-authored-by: Dimitar Georgievski <dgeorgievski@gmail.com>
@dgeorgievski dgeorgievski deleted the fix-example-rbac-apps-events branch July 17, 2023 18:18
Jneville0815 pushed a commit to radiusmethod/argo-cd that referenced this pull request Jul 18, 2023
@dgeorgievski @Jneville0815
docs: Correct example ClusterRole to allow Events in any namespace (a…
5f2e0c3 
…rgoproj#14544)

Fixes: argoproj#14477

Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>
@carslen carslen mentioned this pull request Jul 20, 2023
Closed
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
@gcp-cherry-pick-bot @dgeorgievski @schakrad
docs: Correct example ClusterRole to allow Events in any namespace (a…
7520905 
…rgoproj#14544) (argoproj#14551)

Fixes: argoproj#14477

Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
Co-authored-by: Dimitar Georgievski <dgeorgievski@gmail.com>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@dgeorgievski
docs: Correct example ClusterRole to allow Events in any namespace (a…
0a2847a 
…rgoproj#14544)

Fixes: argoproj#14477

Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
@suzaku suzaku mentioned this pull request Aug 15, 2023
Closed
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@dgeorgievski @tesla59
docs: Correct example ClusterRole to allow Events in any namespace (a…
20a6d66 
…rgoproj#14544)

Fixes: argoproj#14477

Signed-off-by: Dimitar Georgievski <dgeorgievski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Applications in any namespace - privileges issues to manage Application details in Argocd UI
3 participants
@dgeorgievski @crenshaw-dev @ishitasequeira