Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) #14578

Merged
merged 10 commits into from
Jul 18, 2023
Merged

fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) #14578

merged 10 commits into from
Jul 18, 2023

Conversation

schakrad
Copy link
Contributor

@schakrad schakrad commented Jul 18, 2023 •
edited by crenshaw-dev
Loading

Fixes #13911

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

schakrad and others added 10 commits December 13, 2022 17:13
@schakrad
argoproj#11602 fix : Object options menu truncated when selected in A…
c7be1ee 
…pplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
@schakrad
Merge branch 'argoproj:master' into master
2e4f3e5
@schakrad
Merge branch 'argoproj:master' into master
dc00d7d
@schakrad
argoproj#11602 fix : Object options menu truncated when selected in A…
130585c 
…pplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
@schakrad
Merge branch 'master' of https://github.com/schakrad/argo-cd
d2871f5
@schakrad
Merge branch 'argoproj:master' into master
3a053d1
@crenshaw-dev
Merge branch 'master' into master
476ab49
@schakrad
Merge branch 'master' of https://github.com/schakrad/argo-cd
7627d0d
@schakrad
changes for argocd_rbac
363b932 
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
@schakrad
Merge branch 'master' of https://github.com/schakrad/argo-cd
4158176 
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
@crenshaw-dev crenshaw-dev changed the title fix: argocd CLI RBAC validation doesn't work on actions #13911 fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) Jul 18, 2023
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.8

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.7

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.6

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.5

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) July 18, 2023 17:51
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dd800ec) 49.82% compared to head (4158176) 49.83%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #14578   +/-   ##
=======================================
  Coverage   49.82%   49.83%           
=======================================
  Files         261      261           
  Lines       44788    44791    +3     
=======================================
+ Hits        22317    22320    +3     
  Misses      20273    20273           
  Partials     2198     2198
Impacted Files Coverage Δ
cmd/argocd/commands/admin/settings_rbac.go 26.63% <100.00%> (+0.91%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit 12a5a7a into argoproj:master Jul 18, 2023
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 18, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 18, 2023
@schakrad @crenshaw-dev
fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) (…
08fd8eb 
…#14578)

* #11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* #11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* changes for argocd_rbac

Signed-off-by: schakrad <chakradari.sindhu@gmail.com>

---------

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 18, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 18, 2023
@schakrad @crenshaw-dev
fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) (…
46e741c 
…#14578)

* #11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* #11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* changes for argocd_rbac

Signed-off-by: schakrad <chakradari.sindhu@gmail.com>

---------

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 18, 2023
@schakrad @crenshaw-dev
fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) (…
81b5844 
…#14578)

* #11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* #11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* changes for argocd_rbac

Signed-off-by: schakrad <chakradari.sindhu@gmail.com>

---------

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 18, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jul 18, 2023
@schakrad @crenshaw-dev
fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) (…
f320177 
…#14578)

* #11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* #11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* changes for argocd_rbac

Signed-off-by: schakrad <chakradari.sindhu@gmail.com>

---------

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jul 18, 2023
Merged
crenshaw-dev added a commit that referenced this pull request Jul 18, 2023
@gcp-cherry-pick-bot @schakrad @crenshaw-dev
fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) (…
68a0d00 
…#14578) (#14581)

* #11602 fix : Object options menu truncated when selected in ApplicationListView.



* #11602 fix : Object options menu truncated when selected in ApplicationListView.



* changes for argocd_rbac



---------

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Co-authored-by: schakrad <58915923+schakrad@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jul 18, 2023
@gcp-cherry-pick-bot @schakrad @crenshaw-dev
fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) (…
62e9973 
…#14578) (#14582)

* #11602 fix : Object options menu truncated when selected in ApplicationListView.



* #11602 fix : Object options menu truncated when selected in ApplicationListView.



* changes for argocd_rbac



---------

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Co-authored-by: schakrad <58915923+schakrad@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jul 18, 2023
@gcp-cherry-pick-bot @schakrad @crenshaw-dev
fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) (…
1974b8a 
…#14578) (#14583)

* #11602 fix : Object options menu truncated when selected in ApplicationListView.



* #11602 fix : Object options menu truncated when selected in ApplicationListView.



* changes for argocd_rbac



---------

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Co-authored-by: schakrad <58915923+schakrad@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Jul 18, 2023
@gcp-cherry-pick-bot @schakrad @crenshaw-dev
fix(cli): argocd CLI RBAC validation doesn't work on actions (#13911) (…
21988d8 
…#14578) (#14584)

* #11602 fix : Object options menu truncated when selected in ApplicationListView.



* #11602 fix : Object options menu truncated when selected in ApplicationListView.



* changes for argocd_rbac



---------

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Co-authored-by: schakrad <58915923+schakrad@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@carslen carslen mentioned this pull request Jul 20, 2023
Closed
schakrad added a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
@gcp-cherry-pick-bot @schakrad @crenshaw-dev
fix(cli): argocd CLI RBAC validation doesn't work on actions (argopro…
4e0a678 
…j#13911) (argoproj#14578) (argoproj#14582)

* argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView.

* argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView.

* changes for argocd_rbac

---------

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Co-authored-by: schakrad <58915923+schakrad@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@schakrad @crenshaw-dev
fix(cli): argocd CLI RBAC validation doesn't work on actions (argopro…
63924f3 
…j#13911) (argoproj#14578)

* argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* changes for argocd_rbac

Signed-off-by: schakrad <chakradari.sindhu@gmail.com>

---------

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@suzaku suzaku mentioned this pull request Aug 15, 2023
Closed
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@schakrad @crenshaw-dev @tesla59
fix(cli): argocd CLI RBAC validation doesn't work on actions (argopro…
30637a2 
…j#13911) (argoproj#14578)

* argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* argoproj#11602 fix : Object options menu truncated when selected in ApplicationListView.

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>

* changes for argocd_rbac

Signed-off-by: schakrad <chakradari.sindhu@gmail.com>

---------

Signed-off-by: schakradari <saisindhu_chakradari@intuit.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

argocd CLI RBAC validation doesn't work on actions
2 participants
@schakrad @crenshaw-dev