Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve application readability #14750

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yyzxw
Copy link
Contributor

@yyzxw yyzxw commented Jul 27, 2023

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 68.96% and project coverage change: +0.03% 🎉

Comparison is base (24c080b) 49.86% compared to head (6cc0789) 49.89%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14750      +/-   ##
==========================================
+ Coverage   49.86%   49.89%   +0.03%     
==========================================
  Files         263      263              
  Lines       45190    45195       +5     
==========================================
+ Hits        22535    22552      +17     
+ Misses      20437    20424      -13     
- Partials     2218     2219       +1     
Files Changed Coverage Δ
server/application/logs.go 86.86% <50.00%> (ø)
server/application/application.go 51.42% <57.89%> (+0.55%) ⬆️
pkg/apis/application/v1alpha1/types.go 59.09% <100.00%> (+0.25%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @yyzxw. I like these improvements in readability and the added tests.

I have one concern, PTAL.

server/application/terminal.go Outdated Show resolved Hide resolved
@yyzxw yyzxw force-pushed the chore/enhanced-readability branch from 467b227 to 19547b9 Compare August 1, 2023 09:17
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!! One small nit.

server/application/logs.go Outdated Show resolved Hide resolved
@yyzxw yyzxw force-pushed the chore/enhanced-readability branch from 19547b9 to 8a64926 Compare August 23, 2023 09:47
@yyzxw yyzxw requested a review from jannfis August 23, 2023 09:47
util/argo/argo.go Outdated Show resolved Hide resolved
Signed-off-by: yyzxw <1020938856@qq.com>
@yyzxw yyzxw force-pushed the chore/enhanced-readability branch from 8a64926 to 6cc0789 Compare August 24, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants