Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): cache deadlock on delete and re-add cluster (cherry-pick #14780) #14798

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix(controller): cache deadlock on delete and re-add cluster (#14780)

Signed-off-by: Nathan Romriell nateromriell@gmail.com

Signed-off-by: Nathan Romriell <nateromriell@gmail.com>
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 80.35% and project coverage change: +0.11% 🎉

Comparison is base (7852e44) 49.80% compared to head (2179020) 49.92%.
Report is 1 commits behind head on release-2.8.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.8   #14798      +/-   ##
===============================================
+ Coverage        49.80%   49.92%   +0.11%     
===============================================
  Files              261      261              
  Lines            44884    44929      +45     
===============================================
+ Hits             22356    22431      +75     
+ Misses           20322    20293      -29     
+ Partials          2206     2205       -1     
Files Changed Coverage Δ
applicationset/generators/scm_provider.go 43.21% <68.57%> (+9.88%) ⬆️
applicationset/generators/pull_request.go 60.11% <100.00%> (+15.39%) ⬆️
controller/cache/cache.go 27.01% <100.00%> (+1.91%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit f17eb78 into release-2.8 Jul 31, 2023
@crenshaw-dev crenshaw-dev deleted the cherry-pick-a53fee-release-2.8 branch July 31, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant