Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "fix: surface source not permitted errors (#12255)" (cherry-pick #14858) #14863

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked chore: revert #12255 (#14858)

This reverts commit c651bd8.

Due to the imminent release of 2.8, this needs to be rolled back since
the proposed fix in #14210 cannot make it in time.

Signed-off-by: Blake Pettersson blake.pettersson@gmail.com

This reverts commit c651bd8.

Due to the imminent release of 2.8, this needs to be rolled back since
the proposed fix in #14210 cannot make it in time.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (b4e29cf) 49.93% compared to head (0089297) 49.95%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.8   #14863      +/-   ##
===============================================
+ Coverage        49.93%   49.95%   +0.01%     
===============================================
  Files              261      261              
  Lines            44955    44914      -41     
===============================================
- Hits             22448    22435      -13     
+ Misses           20299    20276      -23     
+ Partials          2208     2203       -5     
Files Changed Coverage Δ
cmd/argocd/commands/app.go 21.86% <0.00%> (+0.06%) ⬆️
cmd/argocd/commands/project.go 0.00% <0.00%> (ø)
controller/state.go 72.40% <ø> (-0.10%) ⬇️
reposerver/repository/repository.go 59.57% <ø> (+0.24%) ⬆️
server/application/application.go 50.82% <ø> (-0.05%) ⬇️
util/argo/argo.go 66.36% <ø> (-0.13%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit 7dd040c into release-2.8 Aug 2, 2023
@crenshaw-dev crenshaw-dev deleted the cherry-pick-d57b00-release-2.8 branch August 2, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants