fix(ui): Change group/grouped visualization argoproj#13565 #14904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vipinachar would you be able to add a screenshot of ui change? |
|
oh sorry, I had uploaded a video seems like there was some error. argo-cd-grouping.mp4 |
|
@ashutosh16 I have uploaded video of my changes |
Signed-off-by: Vipin M S <vipinachar2016@gmail.com>
vipinachar
force-pushed
the
fix-ui-change-grouped-visualisation
branch
from
c2314b4
to
dbd3ef9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14904 +/- ##
==========================================
+ Coverage 49.44% 49.90% +0.45%
==========================================
Files 273 262 -11
Lines 48662 44983 -3679
==========================================
- Hits 24063 22447 -1616
+ Misses 22237 20327 -1910
+ Partials 2362 2209 -153 ☔ View full report in Codecov by Sentry. |
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
Signed-off-by: Vipin M S <vipinachar2016@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13565
I have added the count of resources on resource tile. Please let me know if it needs ant changes
Demo:-
Uploading argo-cd-grouping.mp4…