feat: Added 'slugify' sprig function #15188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aym3nTN
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #15188 +/- ##
==========================================
+ Coverage 49.68% 49.73% +0.04%
==========================================
Files 267 267
Lines 46362 46390 +28
==========================================
+ Hits 23036 23072 +36
+ Misses 21065 21057 -8
Partials 2261 2261
☔ View full report in Codecov by Sentry. |
crenshaw-dev
requested changes
Aug 23, 2023
Aym3nTN
force-pushed
the
slugify-sprig-function
branch
from
6e77137
to
bfb80e0
Compare
|
Just documented the function and wrote the tests, please have a look 👀 |
|
Looks like the unit test failure is Real |
Aym3nTN
force-pushed
the
slugify-sprig-function
branch
from
8e2d60d
to
b4c5e14
Compare
A bad test case from some another MR was added to |
|
@crenshaw-dev All checks have passed 🎉 |
Aym3nTN
force-pushed
the
slugify-sprig-function
branch
2 times, most recently
from
d034619
to
1b528cc
Compare
Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com>
Aym3nTN
force-pushed
the
slugify-sprig-function
branch
from
1b528cc
to
ed2cf7b
Compare
Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com>
|
@crenshaw-dev I've re-resolved the conflicts, would you please merge it this time? |
|
@crenshaw-dev in case you've missed my previous comment
|
crenshaw-dev
approved these changes
Nov 15, 2023
GilUpstream
pushed a commit
to GilUpstream/argo-cd
that referenced
this pull request
Nov 15, 2023
* Added 'slugify' sprig function Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> * Retrigger CI Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> --------- Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> Signed-off-by: Gilad Salmon <gilad.salmon@gmail.com>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
* Added 'slugify' sprig function Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> * Retrigger CI Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> --------- Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* Added 'slugify' sprig function Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> * Retrigger CI Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> --------- Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
* Added 'slugify' sprig function Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> * Retrigger CI Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> --------- Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
* Added 'slugify' sprig function Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> * Retrigger CI Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com> --------- Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10622