-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: self service notification #15704
feat: self service notification #15704
Conversation
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #15704 +/- ##
==========================================
- Coverage 49.97% 49.92% -0.05%
==========================================
Files 266 266
Lines 46027 46092 +65
==========================================
+ Hits 23002 23012 +10
- Misses 20769 20819 +50
- Partials 2256 2261 +5
☔ View full report in Codecov by Sentry. |
@@ -119,6 +119,7 @@ func TestInit(t *testing.T) { | |||
nil, | |||
"my-secret", | |||
"my-configmap", | |||
false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we really oughta have some unit tests for when apps-in-any-namespace is enabled.
@@ -45,3 +45,19 @@ kubectl patch app <my-app> -n argocd -p '{"metadata": {"annotations": {"notifica | |||
``` | |||
|
|||
Try syncing an application to get notified when the sync is completed. | |||
|
|||
## Namespace based configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a description of what happens when there's a "base configuration" defined in the argocd
namespace and also a cm/secret in the App namespace? What happens if keys in the ConfigMaps/Secrets conflict? Which takes precedence? An example or two might help.
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
After reading the docs, I have questions about self-service behavior. I think the answers should be documented and, ideally, unit- or e2e-tested:
I've opted to give the namespaced config the most control. That does take control out of the hands of the admin, making it difficult to "override" user-defined behavior. But I think that, for notifications, that is probably fine. |
After chatting with the team, sounds like this is the conclusion: everything is separate. It's as if a completely different notifications controller were running for the user-defined config, completely unaware of the I think that's a good design for now. Simple, safe, easy to understand. I do think we should make that design explicit in the docs and add tests for the three basic scenarios: 1) config only in |
This is to enable argocd to have self-service notification.
This PR needs #15702 as pre-requisite.
Checklist: