Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to k8s.io/apiserver@v0.24.17 and k8s.io/kubernetes@v1.24.17 #15712

Closed

Conversation

shuker85
Copy link
Contributor

@shuker85 shuker85 commented Sep 28, 2023

Fixes #15628
Signed-off-by: Shyukri Shyukriev shyukri.shyukriev@mariadb.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@shuker85 shuker85 requested a review from a team as a code owner September 28, 2023 13:47
@shuker85
Copy link
Contributor Author

I've done:

go get k8s.io/kubernetes@v1.24.17
go get k8s.io/apiserver@v0.24.17
go mod tidy

Let me know if the changes in go.sum are desired

@shuker85 shuker85 changed the title chore: bump to k8s.io/apiserverv0.24.17 and k8s.io/kubernetes@v1.24.17 chore: bump to k8s.io/apiserver@v0.24.17 and k8s.io/kubernetes@v1.24.17 Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f93b2e4) 49.76% compared to head (88cfcf7) 49.76%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15712   +/-   ##
=======================================
  Coverage   49.76%   49.76%           
=======================================
  Files         267      267           
  Lines       46296    46296           
=======================================
+ Hits        23038    23039    +1     
+ Misses      20998    20997    -1     
  Partials     2260     2260           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev
Copy link
Member

@shuker85 just merged a PR to add retries to e2e test runs, so if you rebase things should be less likely to flake. :-)

@shuker85 shuker85 force-pushed the chore/upgrade-k8s-apiserver branch 3 times, most recently from 51aaae4 to 88eefa3 Compare September 29, 2023 05:32
@todaywasawesome todaywasawesome enabled auto-merge (squash) October 5, 2023 14:48
Fixes argoproj#15628
Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com>
auto-merge was automatically disabled October 10, 2023 07:23

Head branch was pushed to by a user without write access

@shuker85
Copy link
Contributor Author

@crenshaw-dev back to green.

@blakepettersson
Copy link
Member

With #15852 the versions are now:

argo-cd/go.mod

Line 283 in bf80422

k8s.io/kubernetes v1.26.4 // indirect

argo-cd/go.mod

Line 307 in bf80422

k8s.io/client-go => k8s.io/client-go v0.26.4

but perhaps worth backporting this to 2.8 - 2.9 @crenshaw-dev?

@blakepettersson
Copy link
Member

Closing since this has since been superseded by #15852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argo CD is being flagged as vulnerable by Trivy
3 participants