Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip server certificate verification for http requests in e2e tests #15733

Merged
merged 4 commits into from
Oct 6, 2023
Merged

chore: skip server certificate verification for http requests in e2e tests #15733

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
393bded
chore: skip verifying server certificate for http requests in e2e tests
ChristopherFry Sep 29, 2023
2110a2f
Merge branch 'master' into cfry/test-http-request-insecure
ChristopherFry Oct 4, 2023
a356a39
chore: skip certificate verification only for remote tests
ChristopherFry Oct 5, 2023
d980579
Merge branch 'master' into cfry/test-http-request-insecure
ChristopherFry Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion test/e2e/fixture/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package fixture

import (
"bytes"
"crypto/tls"
"encoding/json"
"io"
"net/http"
Expand All @@ -27,7 +28,14 @@ func DoHttpRequest(method string, path string, data ...byte) (*http.Response, er
return nil, err
}
req.AddCookie(&http.Cookie{Name: common.AuthCookieName, Value: token})
return http.DefaultClient.Do(req)

httpClient := &http.Client{
Transport: &http.Transport{
TLSClientConfig: &tls.Config{InsecureSkipVerify: IsRemote()},
},
}

return httpClient.Do(req)
}

// DoHttpJsonRequest executes a http request against the Argo CD API server and unmarshals the response body as JSON
Expand Down
Loading