fix(banzai/KafkaCluster): Update health.lua

[OneCricketeer]

Updates the Lua logic to more correctly count broker objects

Closes #15963

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.

[ctrlaltluc]

@OneCricketeer thanks for your help with this! I left some questions, mostly for my understanding. Thanks in advance for your patience! (:

[ecojan]

Tried running this locally with lua,
The Lua # operator only counts entries with integer keys so might not work here,
can you try something similar with

        counter = 0
        brokers = 0
        for _, broker in pairs(obj.status.brokersState) do
            if broker.configurationState == "ConfigInSync" then
                if broker.gracefulActionState.cruiseControlState == "GracefulUpscaleSucceeded" or broker.gracefulActionState.cruiseControlState == "GracefulDownscaleSucceeded" then
                    counter = counter + 1
                end
            end
            brokers = brokers + 1
        end
        if counter == brokers then        

[OneCricketeer]

only counts entries with integer keys

@ecojan Thanks, but I'm not so sure? It's a table length operator. You can look at my commit history, and you'll see I tried the explicit counter, and the tests were still failing with that, so something else is causing the tests to fail, and I'm just not seeing it.

Ref https://en.m.wikibooks.org/wiki/Lua_Programming/length_operator

I converted my logic to Python even, and I cannot reproduce the failure

I may need to look more at how I can setup this test bed locally and setup a debugger

[OneCricketeer]

Ah, I see.

length operator returns zero for tables when the first numeric key is nil or there are no numeric keys.

Apologies.

Also see Stackoverflow answers simply suggesting not to use # and rather do explicit loop

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9e0e8d5) 49.62% compared to head (7328136) 49.62%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #15962   +/-   ##
=======================================
  Coverage   49.62%   49.62%           
=======================================
  Files         267      267           
  Lines       46479    46479           
=======================================
  Hits        23063    23063           
  Misses      21144    21144           
  Partials     2272     2272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[34fathombelow]

LGTM

[alex-necula]

Looks good! Can we merge this PR?