Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add examples to --help output for "delete PROJECT ROLE-NAME" #15986

Merged
merged 3 commits into from
Oct 17, 2023
Merged

feat: Add examples to --help output for "delete PROJECT ROLE-NAME" #15986

merged 3 commits into from
Oct 17, 2023

Conversation

Shauryagulati
Copy link
Contributor

Created abother PR to address #15690 #L176

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@Shauryagulati
feat: Add examples to --help output for delete PROJECT ROLE-NAME
d6d80b7 
Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>
@Shauryagulati Shauryagulati requested review from a team as code owners October 16, 2023 16:29
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (dbc48f3) 49.67% compared to head (1dd0165) 49.66%.
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15986      +/-   ##
==========================================
- Coverage   49.67%   49.66%   -0.01%     
==========================================
  Files         267      267              
  Lines       46383    46394      +11     
==========================================
+ Hits        23039    23043       +4     
- Misses      21084    21091       +7     
  Partials     2260     2260
Files Coverage Δ
cmd/argocd/commands/project_role.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shauryagulati
updated file
2f0d520 
Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>
@Shauryagulati
updated file
1dd0165 
Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>
@ishitasequeira ishitasequeira merged commit df32338 into argoproj:master Oct 17, 2023
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@Shauryagulati @ymktmk
feat: Add examples to --help output for "delete PROJECT ROLE-NAME" (a…
9a65b94 
…rgoproj#15986)

* feat: Add examples to --help output for delete PROJECT ROLE-NAME

Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>

---------

Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@Shauryagulati @jmilic1
feat: Add examples to --help output for "delete PROJECT ROLE-NAME" (a…
4a55e22 
…rgoproj#15986)

* feat: Add examples to --help output for delete PROJECT ROLE-NAME

Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>

---------

Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@Shauryagulati @vladfr
feat: Add examples to --help output for "delete PROJECT ROLE-NAME" (a…
7a35238 
…rgoproj#15986)

* feat: Add examples to --help output for delete PROJECT ROLE-NAME

Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>

---------

Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@Shauryagulati @tesla59
feat: Add examples to --help output for "delete PROJECT ROLE-NAME" (a…
a4f72b4 
…rgoproj#15986)

* feat: Add examples to --help output for delete PROJECT ROLE-NAME

Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>

---------

Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>
lukaszgyg pushed a commit to lukaszgyg/argo-cd that referenced this pull request Jan 12, 2024
@Shauryagulati @lukaszgyg
feat: Add examples to --help output for "delete PROJECT ROLE-NAME" (a…
02e844d 
…rgoproj#15986)

* feat: Add examples to --help output for delete PROJECT ROLE-NAME

Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>

---------

Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@Shauryagulati @Hariharasuthan99
feat: Add examples to --help output for "delete PROJECT ROLE-NAME" (a…
ef0f942 
…rgoproj#15986)

* feat: Add examples to --help output for delete PROJECT ROLE-NAME

Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>

---------

Signed-off-by: Shauryagulati <Sgulati1020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shauryagulati @ishitasequeira @crenshaw-dev