Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add example to --help output for argocd_admin_dashboard.go file #16034

Merged
merged 1 commit into from
Oct 19, 2023
Merged

feat: add example to --help output for argocd_admin_dashboard.go file #16034

merged 1 commit into from
Oct 19, 2023

Conversation

akagami-harsh
Copy link
Contributor

@akagami-harsh
add example to --help command in argocd_admin_dashboard.md file
ecb80df 
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@akagami-harsh akagami-harsh requested review from a team as code owners October 19, 2023 10:28
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d7cd236) 49.54% compared to head (ecb80df) 49.53%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #16034      +/-   ##
==========================================
- Coverage   49.54%   49.53%   -0.01%     
==========================================
  Files         269      269              
  Lines       46583    46583              
==========================================
- Hits        23079    23076       -3     
- Misses      21232    21234       +2     
- Partials     2272     2273       +1
Files Coverage Δ
cmd/argocd/commands/admin/dashboard.go 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pasha-codefresh
pasha-codefresh approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pasha-codefresh pasha-codefresh merged commit ab1cc50 into argoproj:master Oct 19, 2023
22 checks passed
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@akagami-harsh @ymktmk
add example to --help command in argocd_admin_dashboard.md file (argo…
c44aa58 
…proj#16034)

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@akagami-harsh @jmilic1
add example to --help command in argocd_admin_dashboard.md file (argo…
697931a 
…proj#16034)

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@akagami-harsh @vladfr
add example to --help command in argocd_admin_dashboard.md file (argo…
e0e1c4e 
…proj#16034)

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@akagami-harsh @tesla59
add example to --help command in argocd_admin_dashboard.md file (argo…
40d8bee 
…proj#16034)

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@akagami-harsh @Hariharasuthan99
add example to --help command in argocd_admin_dashboard.md file (argo…
ed87f4a 
…proj#16034)

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akagami-harsh @pasha-codefresh