Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added example to admin-cluster.go and projectwindow.go files new PR #16103

Closed
wants to merge 5 commits into from
Closed

Conversation

surajyadav1108
Copy link
Contributor

@surajyadav1108 surajyadav1108 commented Oct 25, 2023

added examples for the admin/cluster.go and projectwindow.go files. there were some CI- test issues in the last one so this one is tested first on my forked branch.
part of the issue:https: #15690

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
@surajyadav1108 surajyadav1108 requested review from a team as code owners October 25, 2023 09:05
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (6e2f2c9) 49.56% compared to head (ed697ba) 49.44%.

❗ Current head ed697ba differs from pull request most recent head 508b874. Consider uploading reports for the commit 508b874 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16103      +/-   ##
==========================================
- Coverage   49.56%   49.44%   -0.12%     
==========================================
  Files         269      269              
  Lines       46668    46771     +103     
==========================================
- Hits        23131    23128       -3     
- Misses      21263    21368     +105     
- Partials     2274     2275       +1     
Files Coverage Δ
cmd/argocd/commands/admin/cluster.go 0.00% <0.00%> (ø)
cmd/argocd/commands/projectwindows.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surajyadav1108, can you resolve the conflicts?

Signed-off-by: Suraj yadav <harrypotter1108@gmail.com>
@surajyadav1108
Copy link
Contributor Author

surajyadav1108 commented Oct 26, 2023

@ishitasequeira resolved you can review now
one thing because of this resolve "check changes to generate code" might fails because of editing the docs file
as we need to do make codegen before commiting the changes to cmd file which autogenrates the same thing for docs file.

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
@surajyadav1108 surajyadav1108 closed this by deleting the head repository Oct 26, 2023
@surajyadav1108
Copy link
Contributor Author

surajyadav1108 commented Oct 26, 2023

@ishitasequeira
conflicts were resolved but had to make sure to do "make codegen" again on local branch to clear the one failing test and I messed up during the git pull origin which resulted in whole mess opening up a new fork and a new PR will tag here for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants