Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Cherry pick #15973 into 2.8 #16124

Merged
merged 1 commit into from
Oct 26, 2023
Merged

feat: Cherry pick #15973 into 2.8 #16124

merged 1 commit into from
Oct 26, 2023

Conversation

thomassandslyst
Copy link

This cherry-picks #15973 into release-2.8 as a merge conflict in the documentation stopped the bot.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@peschmae @thomassandslyst
feat(cmp): Print stderr output from command even on success (argoproj…
848e2d6 
…#15921) (argoproj#15973)

* feat(cmp): Print stderr output from command even on success

Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com>

* docs(cmp): Document logging from cmp sidecard for development purposes

Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com>

---------

Signed-off-by: Mathias Petermann <mathias.petermann@gmail.com>
Signed-off-by: Thomas Sands <thomas.sands@ly.st>
@thomassandslyst thomassandslyst requested review from a team as code owners October 26, 2023 15:23
@thomassandslyst thomassandslyst changed the base branch from master to release-2.8 October 26, 2023 15:25
@thomassandslyst thomassandslyst changed the title Cherry pick #15973 into 2.8 feat: Cherry pick #15973 into 2.8 Oct 26, 2023
@crenshaw-dev crenshaw-dev merged commit 7415f47 into argoproj:release-2.8 Oct 26, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomassandslyst @crenshaw-dev @peschmae