feat(ui): Add sourceNamespaces field to projects UI (#15196)

[jdvgh]

Closes #15196

• This PR adds the field sourceNamespaces which is already defined in the AppProject CRD to the ProjectDetails UI

• it is defined as follows (see manifests/crds/appproject-crd.yaml):

              sourceNamespaces:
                description: SourceNamespaces defines the namespaces application resources
                  are allowed to be created in
                items:
                  type: string
                type: array

• From what I figured there is no test for the AppProject UI yet so I'd have to write one from scratch which would rely not only on my change but on the whole AppProject UI - maybe this would be a whole other issue/feature.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19fa5b9) 49.50% compared to head (001cd10) 49.50%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #16249   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         269      269           
  Lines       47430    47430           
=======================================
  Hits        23479    23479           
  Misses      21645    21645           
  Partials     2306     2306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[crenshaw-dev]

Thanks for the PR, @jdvgh!

Could we make it so that this panel only appears if the apps-in-any-namespace feature is enabled?

[jdvgh]

Copying from the issue:

@crenshaw-dev Could you give me a pointer on how I'd check whether apps-in-any-namespace is enabled?
I noticed application-tiles.tsx uses useAuthSettingsCtx?.appsInAnyNamespaceEnabled
where
const useAuthSettingsCtx = React.useContext(AuthSettingsCtx); however I'm not that deep into TypeScript and React to know whether this could and should be re-used in settings/components/project-details/project-details.tsx

[crenshaw-dev]

@jdvgh I think it's safe to reuse here. Checking w/ a colleague...

[crenshaw-dev]

Checked w/ Ashutosh Singh, you should be good to go using that Ctx.

[jdvgh]

@crenshaw-dev added it to be specific to appsInAnyNamespaceEnabled. Tested it by (un)setting:

data:
  application.namespaces: test-*

in argocd-cmd-params-cm.

[crenshaw-dev]

I've assigned Ashutosh to review this in my team's next sprint (starting tomorrow). You can expect a review in the next two weeks!

[ashutosh16]

UI seems good to me.

[ashutosh16]

LGTM

[jdvgh]

@ashutosh16 @crenshaw-dev thanks for the Review 🥂 - do I need to do anything more now? For me it still says:

Merging is blocked
Merging can be performed automatically with 1 approving review.

[crenshaw-dev]

Thanks, @jdvgh!