Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: callout the need to restart pods to pickup service accounts #16610

Merged
merged 1 commit into from
Dec 15, 2023
Merged

docs: callout the need to restart pods to pickup service accounts #16610

merged 1 commit into from
Dec 15, 2023

Conversation

dennispan
Copy link
Contributor

@dennispan dennispan commented Dec 14, 2023 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@dennispan dennispan requested review from a team as code owners December 14, 2023 17:27
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6d8a01) 49.51% compared to head (d1d926e) 49.51%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16610   +/-   ##
=======================================
  Coverage   49.51%   49.51%           
=======================================
  Files         270      270           
  Lines       47498    47498           
=======================================
  Hits        23517    23517           
  Misses      21669    21669           
  Partials     2312     2312

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blakepettersson
Copy link
Member

@dennispan you need to signoff your commit: https://github.com/argoproj/argoproj/blob/master/community/CONTRIBUTING.md#legal

@dennispan
docs: callout the need to restart pods to pickup service accounts
d1d926e 
Signed-off-by: Dennis Pan <dennis.pan@outlook.com>
@dennispan
Copy link
Contributor Author

@blakepettersson done

@blakepettersson blakepettersson merged commit 2f22a69 into argoproj:master Dec 15, 2023
25 checks passed
@blakepettersson
Copy link
Member

Awesome, thanks @dennispan!

tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@dennispan @tesla59
docs: callout the need to restart pods to pickup service accounts (ar…
f929d74 
…goproj#16610)

Signed-off-by: Dennis Pan <dennis.pan@outlook.com>
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
@dennispan
docs: callout the need to restart pods to pickup service accounts (ar…
897fa14 
…goproj#16610)

Signed-off-by: Dennis Pan <dennis.pan@outlook.com>
penglongli pushed a commit to penglongli/argo-cd that referenced this pull request Mar 6, 2024
@dennispan @penglongli
docs: callout the need to restart pods to pickup service accounts (ar…
1c2a173 
…goproj#16610)

Signed-off-by: Dennis Pan <dennis.pan@outlook.com>
Signed-off-by: penglongli <pelenli@tencent.com>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@dennispan @lyda
docs: callout the need to restart pods to pickup service accounts (ar…
5d53091 
…goproj#16610)

Signed-off-by: Dennis Pan <dennis.pan@outlook.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@dennispan @Hariharasuthan99
docs: callout the need to restart pods to pickup service accounts (ar…
1452ec2 
…goproj#16610)

Signed-off-by: Dennis Pan <dennis.pan@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakepettersson blakepettersson blakepettersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennispan @blakepettersson