-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade aws-sdk-go from 1.44.317 to 1.49.4. #16641
Conversation
Signed-off-by: Mathieu Bruneau <brunemat@amazon.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16641 +/- ##
==========================================
- Coverage 49.51% 49.51% -0.01%
==========================================
Files 270 271 +1
Lines 47505 47664 +159
==========================================
+ Hits 23524 23602 +78
- Misses 21669 21731 +62
- Partials 2312 2331 +19 ☔ View full report in Codecov by Sentry. |
Thank you for creating this! I wonder if any of the |
You may be right, not that familiar with // indirect, I'm taking a look |
I'm collaborating with @ROunofF and we made progress, I was able to authenticate to a remote EKS cluster using the new Pod Identity feature released Nov 2023 instead of using IRSA. There is no code changes required just bumping the version of the aws sdk. EKS Pod Identity Affects 3 capabilities in ArgoCD:
|
The aws-sdk-go-v2 are coming from the notifications-engine. I opened a PR for this : argoproj/notifications-engine#259 (Draft while testing this) Let us know if this is the right approach to have notifications-engine updated. |
Signed-off-by: Carlos Santana <carrlos@amazon.com>
There is a new PR that supersedes this one #17063 |
Closing |
This update the aws-sdk-go so it will support dynamic auth token (EKS Pod Identities).
Checklist: