Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update azure/kubelogin to v0.1.0 #16661

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bcho
Copy link

@bcho bcho commented Dec 20, 2023

This pull request updates the azure/kubelogin library to v0.1.0, which introduces better support for library usage.

Closes #16797

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (9b27aeb) 49.48% compared to head (709b466) 49.48%.

❗ Current head 709b466 differs from pull request most recent head 338140c. Consider uploading reports for the commit 338140c to get more accurate results

Files Patch % Lines
cmd/argocd-k8s-auth/commands/azure.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16661      +/-   ##
==========================================
- Coverage   49.48%   49.48%   -0.01%     
==========================================
  Files         271      271              
  Lines       47837    47736     -101     
==========================================
- Hits        23671    23620      -51     
+ Misses      21824    21781      -43     
+ Partials     2342     2335       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: hbc <bcxxxxxx@gmail.com>
@@ -322,6 +321,7 @@ replace (
k8s.io/kms => k8s.io/kms v0.26.11
k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.26.11
k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.26.11
k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20230501164219-8b0f38b5fd1f
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be pinned because new version from k8s.io/api does not compatible with current version. Reference: kubernetes/kube-openapi#404

@bcho bcho changed the title [WIP] feat: use new azure/kubelogin feat: update azure/kubelogin to v0.1.0 Jan 9, 2024
@bcho bcho marked this pull request as ready for review January 9, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update azure/kubelogin to v0.1.0
1 participant