Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Prune=false and IgnoreExtraneous options #1680

Merged
merged 34 commits into from
Jun 7, 2019
Merged

Adds Prune=false and IgnoreExtraneous options #1680

merged 34 commits into from
Jun 7, 2019

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jun 3, 2019 •
edited
Loading

Close #1629

@codecov
Copy link

codecov bot commented Jun 3, 2019 •
edited
Loading

Codecov Report

Merging #1680 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1680   +/-   ##
=======================================
  Coverage   34.87%   34.87%           
=======================================
  Files          76       76           
  Lines       11531    11531           
=======================================
  Hits         4022     4022           
  Misses       6965     6965           
  Partials      544      544

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac51f66...9927e86. Read the comment docs.

@alexec alexec changed the title Adds the option to ignore resources when calculating sync status WIP Adds the option to ignore resources when calculating sync status Jun 4, 2019
@alexec alexec requested review from alexmt and jessesuen June 4, 2019 01:50
@alexec alexec mentioned this pull request Jun 4, 2019
Closed
@alexec
Copy link
Contributor Author

alexec commented Jun 4, 2019

Note to self:- check what the generatorOptions apply to? Just CMs? Other resources?

alexec
alexec commented Jun 4, 2019
View reviewed changes
test/e2e/kustomize_test.go Outdated Show resolved Hide resolved
@alexec
Copy link
Contributor Author

alexec commented Jun 4, 2019

generatorOptions applies to BOTH config maps and secrets.

jessesuen
jessesuen reviewed Jun 5, 2019
View reviewed changes
common/common.go Outdated Show resolved Hide resolved
jessesuen
jessesuen reviewed Jun 5, 2019
View reviewed changes
controller/state.go Outdated Show resolved Hide resolved
alexec
alexec commented Jun 5, 2019
View reviewed changes
controller/state.go Outdated Show resolved Hide resolved
@alexec alexec requested a review from jessesuen June 5, 2019 23:02
@alexec alexec changed the title Adds the option to ignore resources when calculating sync status Adds Prune=false and IgnoreExtraneous options Jun 6, 2019
@alexec alexec merged commit 0088955 into argoproj:master Jun 7, 2019
@alexec alexec deleted the sync-option-ignore branch June 7, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen approved these changes

@alexmt alexmt Awaiting requested review from alexmt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide ability to ignore extra application objects (e.g. kustomize nameSuffixHash)
2 participants
@alexec @jessesuen