fix: flaky test - app history command not printing source in consistent order #17615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duced a string array varHistoryKeys Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
ishitasequeira
changed the title
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
…nt order (argoproj#17615) * instead if ranging over the map varHistory to print the history, inroduced a string array varHistoryKeys Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> * update unit test expectation, remove new line in the beginning Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> --------- Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> Signed-off-by: Kevin Lyda <kevin@lyda.ie>
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
…nt order (argoproj#17615) * instead if ranging over the map varHistory to print the history, inroduced a string array varHistoryKeys Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> * update unit test expectation, remove new line in the beginning Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> --------- Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
…nt order (argoproj#17615) * instead if ranging over the map varHistory to print the history, inroduced a string array varHistoryKeys Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> * update unit test expectation, remove new line in the beginning Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> --------- Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses the issue of the order of insertion not being preserved in the printApplicationHistoryTable function. I've modified the function to store source URLs in both a map and a slice, ensuring that the order of insertion is preserved when printing the history table.
Changes Made:
Added a slice to store the order of insertion of source URLs.
Modified the logic to populate the map and slice accordingly.
Updated the printing logic to iterate over the slice and print history entries in the order of insertion.
Checklist: