Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 2 link fixes + hint #17657

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Conversation

deer-wmde
Copy link
Contributor

I fixed 2 links in the docs.


Also there seem to be some words missing in this sentence, but I couldn't figure out what it's supposed to be:

The sync policy to automated + prune, so that child apps are automatically created, synced, and deleted when the manifest is changed, but you may wish to disable this. I've also added the finalizer, which will ensure that your apps are deleted correctly.

My guess is either something like

The sync policy is set to automated + prune, ...

or

The sync policy defaults to automated + prune, ...

fix RBAC link

Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>
Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>
fix link to application-controller role

Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>
@deer-wmde deer-wmde requested review from a team as code owners March 28, 2024 14:06
Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>
@blakepettersson blakepettersson merged commit e26f4fb into argoproj:master Mar 28, 2024
23 checks passed
@deer-wmde deer-wmde deleted the docs/fix-1 branch March 28, 2024 14:41
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
* Update security.md

fix RBAC link

Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>

* Update security.md

Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>

* Update security.md

fix link to application-controller role

Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>

* Update security.md

Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>

---------

Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
* Update security.md

fix RBAC link

Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>

* Update security.md

Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>

* Update security.md

fix link to application-controller role

Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>

* Update security.md

Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>

---------

Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants