-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support alias for helm repo in application source #17840
base: master
Are you sure you want to change the base?
Conversation
69248b8
to
ddd2d8a
Compare
Look good to me. I will take one last look when tests are fixed, For the e2e you need to change the name of your tests. They are used to build the helm release name. It exceeds the 53 chars. Another solution would be to allow to set the release name but this represents more code |
d4161d7
to
5c57790
Compare
9565e8e
to
09b3ed6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Would need a code owner approval |
@OpenGuidou there are some conflicts now which needs to be resolved |
7b93cad
to
ad421f5
Compare
@blakepettersson Done now ! |
Hi @argoproj/argocd-approvers , Could I get a review on this one ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17840 +/- ##
==========================================
+ Coverage 50.65% 50.73% +0.07%
==========================================
Files 315 316 +1
Lines 43344 43415 +71
==========================================
+ Hits 21958 22027 +69
- Misses 18880 18884 +4
+ Partials 2506 2504 -2 ☔ View full report in Codecov by Sentry. |
7403fb3
to
aaaf246
Compare
Hi @blakepettersson , @argoproj/argocd-approvers , @argoproj/argocd-approvers-docs |
Signed-off-by: Guillaume Doussin <guillaume.doussin@gmail.com>
Closes #17621
In terms of user experience, reusing the name we've defined in the repositories (and most probably shorter than the URL) would be better.
I'm proposing here to reuse the helm alias syntax.
It also allows to have a single Application definition that can be reused in different environments (different repoURL/authentication, under the same repo name) if using separated repo and ArgoCD instances.
Checklist: