Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add rerunreport.txt to .gitignore #17848

Merged
merged 1 commit into from
Apr 15, 2024
Merged

chore: Add rerunreport.txt to .gitignore #17848

merged 1 commit into from
Apr 15, 2024

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Apr 15, 2024

gotestsum, used to run tests, generates a file in the source tree to report failed tests and their reruns. This file belongs into .gitignore.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@jannfis
chore: Add rerunreport.txt to .gitignore
e3903b7 
Signed-off-by: jannfis <jann@mistrust.net>
@jannfis jannfis requested a review from a team as a code owner April 15, 2024 15:12
ishitasequeira
ishitasequeira approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira enabled auto-merge (squash) April 15, 2024 15:19
@ishitasequeira ishitasequeira merged commit c740412 into argoproj:master Apr 15, 2024
27 checks passed
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
@jannfis @mkieweg
chore: Add rerunreport.txt to .gitignore (argoproj#17848)
b996e27 
Signed-off-by: jannfis <jann@mistrust.net>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@jannfis @Hariharasuthan99
chore: Add rerunreport.txt to .gitignore (argoproj#17848)
20a4474 
Signed-off-by: jannfis <jann@mistrust.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jannfis @ishitasequeira