fix: invalid revision in re-used manifest cache #17874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdsoumya
approved these changes
Apr 17, 2024
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
webhook-revision-cache
branch
from
b9ed29b
to
6972c37
Compare
|
/cherry-pick release-2.11 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
pasha-codefresh
pushed a commit
that referenced
this pull request
Apr 18, 2024
|
/cherry-pick release-2.11 |
|
/cherry-pick release-2.10 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
|
Cherry-pick failed with |
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes the bug introduced by #16754
Argo CD webhook "moves" cached manifest in redis to the key that matches the new git revision however it does not take into account that cached value has old revision that is used by the application controller. PR fixes that caching layer to replace value of cached revision.