-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove Egress NetworkPolicy for argocd-redis and argocd-redis-ha-haproxy #18367
fix: remove Egress NetworkPolicy for argocd-redis and argocd-redis-ha-haproxy #18367
Conversation
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18367 +/- ##
==========================================
- Coverage 45.68% 45.68% -0.01%
==========================================
Files 353 353
Lines 46947 46965 +18
==========================================
+ Hits 21447 21454 +7
- Misses 22761 22772 +11
Partials 2739 2739 ☔ View full report in Codecov by Sentry. |
Rather than changing network policy could we move the init container to something that already has access like Argo CD itself? |
@todaywasawesome This is an interesting idea and in theory it should work. However all our tests were done with the init container defined as part of Redis itself. I'm not sure if switching it to the Argo CD pods would be the best strategy at this point as it could introduce more edge cases. |
I don't want to hold it up so I think we should move ahead and take it as an enhancement to move it later. Modifying the policy will get people unblocked but I think it's a security issue to give access for what should be a once in a lifetime execution. |
On a side note I think the docs are excellent here @mayzhang2000 |
/cherry-pick release-2.11 |
/cherry-pick release-2.10 |
…-haproxy (#18367) * fix: runing local failed Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> * fix: Redis egress removal Signed-off-by: May Zhang <may_zhang@intuit.com> --------- Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> Signed-off-by: May Zhang <may_zhang@intuit.com> Co-authored-by: yyzxw <1020938856@qq.com>
/cherry-pick release-2.9 |
Cherry-pick failed with |
Cherry-pick failed with |
I think I am hitting this (timeout) issue on v2.8.19. Is there a plan to release this as a patch to v2.8?
|
…-haproxy (argoproj#18367) - 2.8 Signed-off-by: pashakostohrys <pavel@codefresh.io>
When will this fix be available in release? |
…-haproxy (argoproj#18367) * fix: runing local failed Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> * fix: Redis egress removal Signed-off-by: May Zhang <may_zhang@intuit.com> --------- Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> Signed-off-by: May Zhang <may_zhang@intuit.com> Co-authored-by: yyzxw <1020938856@qq.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
…-haproxy (argoproj#18367) * fix: runing local failed Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> * fix: Redis egress removal Signed-off-by: May Zhang <may_zhang@intuit.com> --------- Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> Signed-off-by: May Zhang <may_zhang@intuit.com> Co-authored-by: yyzxw <1020938856@qq.com>
…-haproxy (argoproj#18367) * fix: runing local failed Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> * fix: Redis egress removal Signed-off-by: May Zhang <may_zhang@intuit.com> --------- Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> Signed-off-by: May Zhang <may_zhang@intuit.com> Co-authored-by: yyzxw <1020938856@qq.com>
…-haproxy (argoproj#18367) * fix: runing local failed Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> * fix: Redis egress removal Signed-off-by: May Zhang <may_zhang@intuit.com> --------- Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io> Signed-off-by: May Zhang <may_zhang@intuit.com> Co-authored-by: yyzxw <1020938856@qq.com> Signed-off-by: Javier Solana <javier.solana@cabify.com> Signed-off-by: Javier Solana <javier.solana@cabify.com>
Checklist: