-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix source ordering issue in manifest generation for multi-source app while using manifests and diff commands #18395
fix: fix source ordering issue in manifest generation for multi-source app while using manifests and diff commands #18395
Conversation
… while using manifests and diff commands Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18395 +/- ##
=======================================
Coverage 44.94% 44.94%
=======================================
Files 354 354
Lines 47739 47740 +1
=======================================
+ Hits 21454 21455 +1
Misses 23482 23482
Partials 2803 2803 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thank you!
/cherry-pick release-2.11 |
… while using manifests and diff commands (#18395)
… while using manifests and diff commands (argoproj#18395) Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
… while using manifests and diff commands (argoproj#18395)
… while using manifests and diff commands (argoproj#18395)
… while using manifests and diff commands (argoproj#18395) Signed-off-by: Javier Solana <javier.solana@cabify.com> Signed-off-by: Javier Solana <javier.solana@cabify.com>
Fixes #18359.
To be cherry-picked in release-2.11.
Checklist: