Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): remove docs for non-existing argocd app set flags (#18671) #18673

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

crenshaw-dev
Copy link
Member

These flags don't actually exist.

Fixes #18671

…roj#18671)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev requested review from a team as code owners June 14, 2024 17:39
Copy link

bunnyshell bot commented Jun 14, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Jun 14, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.56%. Comparing base (9f1e2e8) to head (7c0319d).
Report is 514 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #18673   +/-   ##
=======================================
  Coverage   47.56%   47.56%           
=======================================
  Files         332      332           
  Lines       46746    46747    +1     
=======================================
+ Hits        22236    22237    +1     
+ Misses      21665    21664    -1     
- Partials     2845     2846    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishitasequeira ishitasequeira merged commit 2c0cc02 into argoproj:master Jun 14, 2024
28 checks passed
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
…roj#18671) (argoproj#18673)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@yuliya-roth
Copy link

Thanks,
when do you think these flags will actually be included in argocd?

ggjulio pushed a commit to ggjulio/argo-cd that referenced this pull request Jul 21, 2024
…roj#18671) (argoproj#18673)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
jsolana pushed a commit to jsolana/argo-cd that referenced this pull request Jul 24, 2024
…roj#18671) (argoproj#18673)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--parameter-file and --from-file documented but don't exist for argocd app set
3 participants