Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore mocks in codecov #18685

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

crenshaw-dev
Copy link
Member

Mocks are generally generated and shouldn't be counted in code coverage.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner June 15, 2024 17:58
Copy link

bunnyshell bot commented Jun 15, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@ishitasequeira ishitasequeira enabled auto-merge (squash) June 15, 2024 18:45
@ishitasequeira ishitasequeira merged commit 1ecd397 into argoproj:master Jun 15, 2024
26 checks passed
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
ggjulio pushed a commit to ggjulio/argo-cd that referenced this pull request Jul 21, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
jsolana pushed a commit to jsolana/argo-cd that referenced this pull request Jul 24, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.22%. Comparing base (38d6db6) to head (b3865fd).
Report is 499 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18685      +/-   ##
==========================================
+ Coverage   47.56%   50.22%   +2.66%     
==========================================
  Files         332      312      -20     
  Lines       46747    42955    -3792     
==========================================
- Hits        22235    21574     -661     
+ Misses      21665    18904    -2761     
+ Partials     2847     2477     -370     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants