chore: enable require-error rule from errorlint linter on controller folder #18690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18690 +/- ##
==========================================
+ Coverage 50.23% 50.25% +0.01%
==========================================
Files 312 312
Lines 42969 42969
==========================================
+ Hits 21586 21593 +7
+ Misses 18902 18896 -6
+ Partials 2481 2480 -1 ☔ View full report in Codecov by Sentry. |
…folder Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
testifylint/controller
branch
from
f220b2f
to
0d2e15e
Compare
Signed-off-by: pasha-codefresh <pavel@codefresh.io>
pasha-codefresh
approved these changes
Jun 17, 2024
ggjulio
pushed a commit
to ggjulio/argo-cd
that referenced
this pull request
Jul 21, 2024
…folder (argoproj#18690) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
jsolana
pushed a commit
to jsolana/argo-cd
that referenced
this pull request
Jul 24, 2024
…folder (argoproj#18690) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Signed-off-by: Javier Solana <javier.solana@cabify.com> Signed-off-by: Javier Solana <javier.solana@cabify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.