Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Grafana dashboard.json due to removal of AngularJS support in Grafana #18964

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bhavinkotak
Copy link

@bhavinkotak bhavinkotak commented Jul 5, 2024

Due to the removal of AngularJS support in Grafana - this change is updating the Grafana dashboard for ArgoCD to be compliant.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Changes related to AnugularJS deprecation in Grafana

Signed-off-by: Bhavin Kotak <kotak.bhavin@gmail.com>
@bhavinkotak bhavinkotak requested a review from a team as a code owner July 5, 2024 21:29
Copy link

bunnyshell bot commented Jul 5, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-mgmzdp.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-mgmzdp.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Jul 5, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bhavinkotak bhavinkotak changed the title Update dashboard.json Fix - Example Grafana dashboard.json Jul 5, 2024
@bhavinkotak bhavinkotak changed the title Fix - Example Grafana dashboard.json fix: Example Grafana dashboard.json Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.64%. Comparing base (a071f93) to head (734a2ac).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18964      +/-   ##
==========================================
- Coverage   50.65%   50.64%   -0.01%     
==========================================
  Files         315      315              
  Lines       43286    43286              
==========================================
- Hits        21926    21922       -4     
- Misses      18861    18864       +3     
- Partials     2499     2500       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhavinkotak bhavinkotak changed the title fix: Example Grafana dashboard.json chore: update Grafana dashboard.json due to removal of AngularJS support in Grafana Jul 8, 2024
@ofaz
Copy link
Contributor

ofaz commented Jul 14, 2024

This should close the issue created by Rory : #19027 Upgrade deprecated example dashboard panels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants