Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ApplicationSource.Equal return false negative (#18632) #18970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nattawitc
Copy link

@nattawitc nattawitc commented Jul 7, 2024

Fixes: #18632

go's standard JSON library escape all HTML special character which cause Equal function to return false when comparing escaped and unescaped characters.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

when comparing string with escaped and unescaped representation.

Signed-off-by: Nattawit Chaiworawitsakul <c.nattawit@gmail.com>
@nattawitc nattawitc requested a review from a team as a code owner July 7, 2024 10:30
Copy link

bunnyshell bot commented Jul 7, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-5qawyq.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-5qawyq.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Jul 7, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.65%. Comparing base (b909993) to head (a8feae1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #18970   +/-   ##
=======================================
  Coverage   50.64%   50.65%           
=======================================
  Files         315      315           
  Lines       43286    43295    +9     
=======================================
+ Hits        21924    21929    +5     
- Misses      18859    18865    +6     
+ Partials     2503     2501    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"&" string in valuesObject mess up PARAMETERS tab on argocd's web ui
1 participant