-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding author/creator as a template key for Pull Request Generator #18974
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18974 +/- ##
=======================================
Coverage 50.70% 50.71%
=======================================
Files 316 316
Lines 43496 43503 +7
=======================================
+ Hits 22054 22061 +7
Misses 18930 18930
Partials 2512 2512 ☔ View full report in Codecov by Sentry. |
The tests that fials are the e2e integration-tests. They error while waiting for an application. Not sure how to fix this.
|
Other then that, I think this PR is ready for review. Atleast ready for some critique of the PR itself, all comments are welcome. |
@vfaergestad for e2e failing please look at the PR #17907 for files to update, they are similar. Btw @agaudreault, I saw you updated some files I rebased to fix conflicts, any way I could get a review of #17907 ? |
All test are now successful, and the PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM.
@vfaergestad the commit history looks messed up. Could you try to fix that?
@ishitasequeira Good point! I cleaned it up now. |
Hey @vfaergestad , there is an issue with the number of files changed.
|
5ac7c88
to
c72c86f
Compare
Signed-off-by: Vegard Færgestad <vegardf@mnemonic.no>
Thank you for the notice @ggjulio . I did not release I had made that error. Thank you for your patience, I learn something new everyday. I believe I have fixed it now. Let me know if there is anything else. |
@ishitasequeira Is it anything else needed from my side in this PR? :D |
…tor (argoproj#18974) Signed-off-by: Vegard Færgestad <vegardf@mnemonic.no> Co-authored-by: Vegard Færgestad <vegardf@mnemonic.no> Signed-off-by: Rhys Williams <rhys.williams@electrum.co.za>
Fixes [ISSUE #18826].
Adding an ´author´ template key for the pull request generator. This is retrieved from the SCM api together with the other template keys. This makes it possible to reference the author of an pull-request in the generator-template, for example in the image tag.
Checklist: