-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump k8s libs from 0.29.6 to 0.30.4 #19074
Conversation
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
The option of go-to-protobuf may be changed, so this CI would fail. This problem occur in #18506 , too. |
@sivchari ah gotcha. Want to just update that PR, and I'll close this one? |
@crenshaw-dev |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
… 0.30.x Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codegen failure:
Caused by this change in go-to-protobuf: kubernetes/code-generator@e52957c Not sure yet how to fix it. |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
I just modified the script to copy dependencies from the vendor directory to the location go-to-protobuf expects them to be at. |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19074 +/- ##
=========================================
Coverage ? 55.86%
=========================================
Files ? 316
Lines ? 43784
Branches ? 0
=========================================
Hits ? 24458
Misses ? 16776
Partials ? 2550 ☔ View full report in Codecov by Sentry. |
Sorry for not being able to respond. Brilliant, thanks. |
You're good! No real rush, just wanna sort it in time for 2.13. |
Questions I may or may not have time to answer before pushing to get this merged:
A lot of this codegen stuff is deep lore that goes back before my time, so I'm not sure how safe it is to ignore these oddities. |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Toolchain line wasn't necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested locally (not checked out in gopath) and it works with updated tools. But i don't know what the violation list is for. Maybe @jannfis know?
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Future improvement on codegen can be done in other PRs
Based on: https://github.com/argoproj/gitops-engine/pull/579/files