chore(deps): bump k8s libs from 0.29.6 to 0.30.4

[crenshaw-dev]

Based on: https://github.com/argoproj/gitops-engine/pull/579/files

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[sivchari]

The option of go-to-protobuf may be changed, so this CI would fail. This problem occur in #18506 , too.

[crenshaw-dev]

@sivchari ah gotcha. Want to just update that PR, and I'll close this one?

[sivchari]

@crenshaw-dev
Sure. I want to progress the way to resolve the issue in #18506 with us. Perhaps, this problem is just resolved to solve the go-to-protobuf.

[crenshaw-dev]

Codegen failure:

+ go-to-protobuf --go-header-file=/home/runner/go/src/github.com/argoproj/argo-cd/hack/custom-boilerplate.go.txt --packages=github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1 --apimachinery-packages=+k8s.io/apimachinery/pkg/util/intstr,+k8s.io/apimachinery/pkg/api/resource,+k8s.io/apimachinery/pkg/runtime/schema,+k8s.io/apimachinery/pkg/runtime,k8s.io/apimachinery/pkg/apis/meta/v1,k8s.io/api/core/v1,k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1 --proto-import=/home/runner/go/src/github.com/argoproj/argo-cd/vendor --proto-import=/home/runner/go/src/github.com/argoproj/argo-cd/dist/protoc-include --output-dir=/home/runner/go/src/
2024/07/19 14:28:27 protoc -I . -I /home/runner/go/src/ -I /home/runner/go/src/github.com/argoproj/argo-cd/vendor -I /home/runner/go/src/github.com/argoproj/argo-cd/dist/protoc-include --gogo_out=/home/runner/go/src/ /home/runner/go/src/k8s.io/api/core/v1/generated.proto
2024/07/19 14:28:27 Could not make proto path relative: /home/runner/go/src/k8s.io/api/core/v1/generated.proto: No such file or directory

Caused by this change in go-to-protobuf: kubernetes/code-generator@e52957c

Not sure yet how to fix it.

[crenshaw-dev]

I just modified the script to copy dependencies from the vendor directory to the location go-to-protobuf expects them to be at.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@de53d8e). Learn more about missing BASE report.
Report is 31 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #19074   +/-   ##
=========================================
  Coverage          ?   55.86%           
=========================================
  Files             ?      316           
  Lines             ?    43784           
  Branches          ?        0           
=========================================
  Hits              ?    24458           
  Misses            ?    16776           
  Partials          ?     2550           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sivchari]

Sorry for not being able to respond. Brilliant, thanks.

[crenshaw-dev]

You're good! No real rush, just wanna sort it in time for 2.13.

[crenshaw-dev]

Questions I may or may not have time to answer before pushing to get this merged:

1. do we need the toolchain line in go.mod?
2. why does go-to-protobuf modify the stuff in vendors (specifically, why does it delete generated.pb.go files, breaking codegen) so that we have to re-run go mod vendor?
3. why is the violations exception list file now empty?

A lot of this codegen stuff is deep lore that goes back before my time, so I'm not sure how safe it is to ignore these oddities.

[crenshaw-dev]

Toolchain line wasn't necessary.

[agaudreault]

LGTM. Tested locally (not checked out in gopath) and it works with updated tools. But i don't know what the violation list is for. Maybe @jannfis know?

[agaudreault]

LGTM. Future improvement on codegen can be done in other PRs