-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(health): support for some rds.crossplane.io resources #19076
feat(health): support for some rds.crossplane.io resources #19076
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
e62e732
to
ebe7e18
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19076 +/- ##
==========================================
+ Coverage 50.64% 50.66% +0.01%
==========================================
Files 315 315
Lines 43359 43359
==========================================
+ Hits 21960 21966 +6
+ Misses 18893 18889 -4
+ Partials 2506 2504 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you able to add tests for the Suspended and Degraded states?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Head branch was pushed to by a user without write access
7e4d1b6
to
96dfa85
Compare
96dfa85
to
a729b70
Compare
Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
a729b70
to
0f03f4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jellyfrog!! LGTM!!
…19076) Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com> Signed-off-by: Vegard Færgestad <vegardf@mnemonic.no>
This PR adds custom health checks for some aws.crossplane.io resources. https://github.com/crossplane-contrib/provider-aws
Checklist: