Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(health): support for some rds.crossplane.io resources #19076

Merged
merged 1 commit into from
Jul 22, 2024
Merged

feat(health): support for some rds.crossplane.io resources #19076

merged 1 commit into from
Jul 22, 2024

Conversation

Jellyfrog
Copy link
Contributor

This PR adds custom health checks for some aws.crossplane.io resources. https://github.com/crossplane-contrib/provider-aws

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@Jellyfrog Jellyfrog requested a review from a team as a code owner July 15, 2024 21:26
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jul 15, 2024 •
edited

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jul 15, 2024 •
edited

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@Jellyfrog Jellyfrog force-pushed the feat/health-crossplane-aws-rds branch from e62e732 to ebe7e18 Compare July 15, 2024 21:59
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.66%. Comparing base (64b76f2) to head (0f03f4b).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19076      +/-   ##
==========================================
+ Coverage   50.64%   50.66%   +0.01%     
==========================================
  Files         315      315              
  Lines       43359    43359              
==========================================
+ Hits        21960    21966       +6     
+ Misses      18893    18889       -4     
+ Partials     2506     2504       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crenshaw-dev
crenshaw-dev previously requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to add tests for the Suspended and Degraded states?

todaywasawesome
todaywasawesome approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@todaywasawesome todaywasawesome enabled auto-merge (squash) July 17, 2024 15:28
@todaywasawesome todaywasawesome enabled auto-merge (squash) July 17, 2024 15:29
auto-merge was automatically disabled July 17, 2024 21:26

Head branch was pushed to by a user without write access

@Jellyfrog Jellyfrog force-pushed the feat/health-crossplane-aws-rds branch 2 times, most recently from 7e4d1b6 to 96dfa85 Compare July 17, 2024 21:27
@Jellyfrog Jellyfrog force-pushed the feat/health-crossplane-aws-rds branch from 96dfa85 to a729b70 Compare July 18, 2024 11:29
@Jellyfrog
feat(health): support for some rds.crossplane.io resources
0f03f4b 
Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
@Jellyfrog Jellyfrog force-pushed the feat/health-crossplane-aws-rds branch from a729b70 to 0f03f4b Compare July 21, 2024 16:16
ishitasequeira
ishitasequeira approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jellyfrog!! LGTM!!

@ishitasequeira ishitasequeira merged commit f26b76a into argoproj:master Jul 22, 2024
28 of 29 checks passed
vfaergestad pushed a commit to vfaergestad/argo-cd that referenced this pull request Jul 22, 2024
@Jellyfrog
feat(health): support for some rds.crossplane.io resources (argoproj#…
f07abb9 
…19076)

Signed-off-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
Signed-off-by: Vegard Færgestad <vegardf@mnemonic.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@crenshaw-dev crenshaw-dev Awaiting requested review from crenshaw-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jellyfrog @crenshaw-dev @todaywasawesome @ishitasequeira