Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1841 Make the health check for APIService a built in #1921

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Issue #1841 Make the health check for APIService a built in #1921

merged 2 commits into from
Jul 11, 2019

Conversation

masa213f
Copy link
Contributor

@masa213f masa213f commented Jul 11, 2019

Fix for #1841. Please review.

APIService has 3 states: True, False or Unknown.
In this fix, when the state is True, it is judged as Healthy. In another state, it is judged as Progressing.
ref: https://godoc.org/k8s.io/kube-aggregator/pkg/apis/apiregistration#ConditionStatus

And APIService has 2 versions: v1 and v1beta1. (v1beta1 is old..)
Some application (like CertManager) suppose to use v1beta1. So I want to support v1beta1 for convenience.

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #1921 into master will increase coverage by 0.13%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1921      +/-   ##
==========================================
+ Coverage   35.42%   35.55%   +0.13%     
==========================================
  Files          85       85              
  Lines       12053    12079      +26     
==========================================
+ Hits         4270     4295      +25     
  Misses       7195     7195              
- Partials      588      589       +1
Impacted Files Coverage Δ
util/kube/kube.go 35.31% <ø> (ø) ⬆️
util/health/health.go 60.55% <78.57%> (+1.38%) ⬆️
util/argo/audit_logger.go 0% <0%> (ø) ⬆️
controller/state.go 71.88% <0%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40ffdf...e4ec71f. Read the comment docs.

@alexec alexec merged commit 641e344 into argoproj:master Jul 11, 2019
@alexec
Copy link
Contributor

alexec commented Jul 11, 2019

great stuff @masa213f - merged!

@alexec alexec added this to the v1.2 milestone Jul 11, 2019
@masa213f
Copy link
Contributor Author

@alexec
It's my pleasure. Thank you for checking!

@masa213f masa213f deleted the apiservice-health-check branch July 11, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants