Issue #1841 Make the health check for APIService a built in #1921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1841. Please review.
APIService
has 3 states:True
,False
orUnknown
.In this fix, when the state is
True
, it is judged asHealthy
. In another state, it is judged asProgressing
.ref: https://godoc.org/k8s.io/kube-aggregator/pkg/apis/apiregistration#ConditionStatus
And
APIService
has 2 versions:v1
andv1beta1
. (v1beta1
is old..)Some application (like CertManager) suppose to use
v1beta1
. So I want to supportv1beta1
for convenience.