feat: refactor writeManifests function for simplification and better error handling (#19446) #19447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error handling Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
crenshaw-dev
reviewed
Aug 8, 2024
Comment on lines
130
to
+139
| buf := bytes.Buffer{} | ||
| enc := yaml.NewEncoder(&buf) | ||
| enc.SetIndent(2) | ||
|
|
||
| defer func() { | ||
| if cerr := enc.Close(); cerr != nil { | ||
| log.WithError(cerr).Error("failed to close yaml encoder") | ||
| } | ||
| }() | ||
|
|
There was a problem hiding this comment.
I wonder if we could skip the bytes buffer entirely and encode directly to the file... not sure how that works with multiple documents.
I assume we'd then use a shared encoder instead of creating a new one for each manifest.
crenshaw-dev
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #19446