Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hydrator): Hydrator Panel Metadata Refresh Issue on Revision Change #19580

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

nueavv
Copy link
Contributor

@nueavv nueavv commented Aug 18, 2024

Closes #19493

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@nueavv nueavv requested review from a team as code owners August 18, 2024 18:29
Copy link

bunnyshell bot commented Aug 18, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Aug 18, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@nueavv nueavv changed the base branch from master to hydrator August 18, 2024 18:30
@nueavv nueavv changed the title Fix Hydrator Panel Metadata Refresh Issue on Revision Change fix: Hydrator Panel Metadata Refresh Issue on Revision Change Aug 19, 2024
Copy link
Contributor

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nueavv , thanks for raising the PR.

The DCO checks are failing. Please sign the commit using the -s option.

Signed-off-by: nueavv <nuguni@kakao.com>
@nueavv
Copy link
Contributor Author

nueavv commented Aug 19, 2024

Hi, @nitishfy I fixed the commit!

@nueavv nueavv requested a review from nitishfy August 20, 2024 03:29
@nueavv nueavv changed the title fix: Hydrator Panel Metadata Refresh Issue on Revision Change fix(hydrator): Hydrator Panel Metadata Refresh Issue on Revision Change Aug 20, 2024
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works beautifully, thank you!

@crenshaw-dev crenshaw-dev merged commit 74b8bfa into argoproj:hydrator Aug 20, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants